# 61 Code review

By kqr

Previously published at https://two-wrongs.com/code-review-checklist

- [ ] <strong>Maintainability</strong>
- [ ] Review request……….IS FOR SMALL, ATOMIC CHANGE
- [ ] Description………….CONTAINS SPEC./REQUIREMENTS
- [ ] Names and concepts………….HAVE OBVIOUS MEANING
- [ ] Non-obvious mechanics…………….ARE DOCUMENTED
- [ ] <strong>Correctness</strong>
- [ ] Business operations……HAVE APPROPRIATE METRICS
- [ ] Test plan………………….PRESENT AND EXECUTED
- [ ] Code in revision…………………BUILDS &amp; RUNS
- [ ] All non-obvious logic…………..COVERED BY TESTS
- [ ] Unit tests…………………TEST MANY EDGE CASES
- [ ] Race conditions……………………CANNOT OCCUR
- [ ] <strong>Invalid Inputs/State</strong>
- [ ] Input box……………..HANDLES ARBITRARY STRINGS
- [ ] Numbers………………………..CAN BE NEGATIVE
- [ ] Integers………………………….CAN OVERFLOW
- [ ] Floating-point values…..HAVE SUFFICIENT PRECISION
- [ ] Strings………………..ARE ESCAPED IF NECESSARY
- [ ] Dates………………………WORK PAST YEAR 2038
- [ ] Network loss………………………..IS HANDLED
- [ ] <strong>Usability</strong>
- [ ] Error messages………….STATE PROBLEM SUCCINCTLY
- [ ] User-facing errors……………..SUGGEST SOLUTION
- [ ] Timestamps…………………….INCLUDE TIMEZONE
- [ ] Pers. ident. information…………..NOT PERSISTED